fix: correctly handle empty elements#73
Merged
pjsier merged 4 commits intogeorust:mainfrom Nov 22, 2025
Merged
Conversation
There is a bug in which when we encounter empty elements, the parsing tree is shifted and the children are asigned to parent elements. One really easy fix is to handle that empty element. Signed-off-by: Ricardo Benitez <benitezc.ricardo@gmail.com>
Signed-off-by: Ricardo Benitez <benitezc.ricardo@gmail.com>
Signed-off-by: Ricardo Benitez <benitez.ricardo@proton.me>
pjsier
approved these changes
Nov 8, 2025
Member
pjsier
left a comment
pjsier
left a comment
There was a problem hiding this comment.
Thanks for catching this! One quick change and I think this is good to go. Sorry for the delay in reviewing
Signed-off-by: Ricardo Benitez <benitezc.ricardo@gmail.com>
pjsier
approved these changes
Nov 22, 2025
Member
pjsier
left a comment
pjsier
left a comment
There was a problem hiding this comment.
Thanks for making that change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in which when we encounter empty elements, the parsing tree is shifted and the children are asigned to parent elements. One really easy fix is to handle that empty element.
CHANGES.mdorCHANGELOG.mdMinor bug fix to parse CustomFields and Empty elements.