Reduce unsafe code in codec through better abstractions#29
Merged
gerben-stavenga merged 2 commits intomasterfrom Jan 4, 2026
Merged
Reduce unsafe code in codec through better abstractions#29gerben-stavenga merged 2 commits intomasterfrom
gerben-stavenga merged 2 commits intomasterfrom
Conversation
- Add Ptr<T> and PtrMut<T> types that encapsulate pointer validity invariant - Add UpdateByValue trait for safe struct field updates - Use Message type instead of raw *mut Object in decoder - Fix lifetimes in set_bytes/add_bytes to eliminate transmute - Check field presence before accessing oneof data in reflection Reduces unsafe blocks in decoding.rs from 15 to 4 and encoding.rs from 11 to 2. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
gerben-stavenga
force-pushed
the
improve-unsafe-use
branch
from
f603e9f to
34e4434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary static from serde impl, that remove unnecessary unsafe + cargo fmt