Fix ty type errors with ignore comments and isinstance assertions#758
Closed
Fix ty type errors with ignore comments and isinstance assertions#758
Conversation
…assertions Co-authored-by: gerlero <15150530+gerlero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix type errors by adding isinstance assertions or resolving issues
Fix ty type errors with ignore comments and isinstance assertions
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved 21 ty type errors across 8 locations by adding type ignore comments where ty's type narrowing is insufficient and isinstance assertions where they improve type safety.
Changes
Source code:
_files/_parsing/__init__.py:244- Addedty: ignore[invalid-assignment]for dict assignment after isinstance check_files/_serialization.py:380- Extended ignore to includenot-iterablefor*dataunpacking_files/files.py:1196- Addedty: ignore[invalid-argument-type]forret[None]accessTests:
test_files.py:101- Addedty: ignore[invalid-assignment]for copy-on-write list mutation testtest_parsing/test_intermediate.py:164-169- Added isinstance checks for tuple/list and dict, with ignore comments for subsequent subscript operations where type narrowing remains insufficientAll fixes target specific ty error codes on lines where type inference limitations prevent proper type narrowing despite runtime assertions.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.