Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the footer component to use a unified layout and consistent external-link cards while improving visuals and adding community/docs links.
Changes:
- Refactors
Footerto a new structured layout with grid-based link cards and updated styling. - Adds shared external link props and expands external destinations (docs, forums, Discord, repo, site, Ko-fi).
- Replaces
<img>usage withnext/imagefor footer assets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const externalLinkProps = { | ||
| target: "_blank", | ||
| rel: "noreferrer", |
There was a problem hiding this comment.
target="_blank" should include rel="noopener noreferrer" (not just noreferrer) to prevent reverse-tabnabbing and ensure consistent protection across browsers. Update externalLinkProps.rel accordingly.
| rel: "noreferrer", | |
| rel: "noopener noreferrer", |
|
|
||
| export default function Footer({ introRef }: { introRef?: RefObject<any> }) { | ||
| type FooterProps = { | ||
| introRef?: RefObject<HTMLDivElement | null>; |
There was a problem hiding this comment.
RefObject<T> already models current as T | null, so using RefObject<HTMLDivElement | null> adds redundant nullability (effectively HTMLDivElement | null | null). Prefer RefObject<HTMLDivElement> to keep the prop type precise and avoid propagating unnecessary null unions.
| introRef?: RefObject<HTMLDivElement | null>; | |
| introRef?: RefObject<HTMLDivElement>; |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
No description provided.