fix: intercept self hold payments based on invoice rather than payment hash

[rolznz]

This PR also fixes a bug where we will fail saying the invoice has already been paid (I think would block wrapped invoices working with LND right now)

TODOs

• undo expiry hack and regenerate invoices
• test in sandbox locally (both wrapped and normal HOLD invoices)
• test with LND (Polar - tested with JS SDK: chore: add example for wrapped invoices js-sdk#529)
• test standard HOLD invoices with LDK (Mutinynet) NOTE: wrapped invoices are not supported yet by LDK-Node.
• test keysend self-payments

Follow ups - move to new issue:

• update Alby Hub to support setting the min_final_cltv_expiry_delta via nwc (needs exposing in our ldk node fork) - moved to Fully Implement NWC HOLD invoices spec #2065

[coderabbitai]

Warning

Rate limit exceeded

@im-adithya has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2174f02 and fd56016.

📒 Files selected for processing (6)

• lnclient/lnd/lnd.go
• tests/mock_ln_client.go
• transactions/hold_invoice_self_payment_consumer.go
• transactions/payments_test.go
• transactions/self_hold_payments_test.go
• transactions/transactions_service.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/self-payments-wrapped-invoice

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rolznz]

@im-adithya @frnandu in the latest version of Polar (LND v20) payments were failing until I set a timeout seconds (which should have been set anyway. I set it to 50s)

[im-adithya]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[im-adithya]

utACK