Draft
Conversation
3 tasks
im-adithya
reviewed
Apr 9, 2025
im-adithya
approved these changes
Apr 9, 2025
Member
im-adithya
left a comment
im-adithya
left a comment
There was a problem hiding this comment.
Just a small comment, otherwise looks good 🙌
Contributor
Author
|
From Bumi: we can explore how to apply this to the existing lightning tools functions - especially to make it easier to use with fiat. But it's not too high priority, let's leave this PR open for now and these types in the JS SDK for now and we can move them later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving
AmountandFiatAmountfrom the LNClient JS SDK PR: getAlby/js-sdk#344Right now the changes do not feel fully integrated with lightning tools and kind of tacked on top and not tightly integrated. For example
fiat.getSatoshiValuereturns a number, not anAmounttype.The
Amounttype andresolveAmountare exported at the root.What do you think?