Conversation
bumi
reviewed
Mar 29, 2025
Contributor
bumi
left a comment
bumi
left a comment
There was a problem hiding this comment.
that looks like a nice and helpful wrapper!
do I read it correct that for each user/wallet I would need to call the subscribe function?
| relay: Relay; | ||
| relayUrl: string; | ||
|
|
||
| constructor(options: NewNWCWalletServiceOptions) { |
Contributor
There was a problem hiding this comment.
why does the wallet service not also have the keypair?
Contributor
Author
There was a problem hiding this comment.
do I read it correct that for each user/wallet I would need to call the subscribe function?
Yes, this is the reason. So that each connection can have unique keypairs, like we do in Alby Hub now
…hared types out of NWCClient
Contributor
Author
|
Merging for now and will add documentation in a follow-up PR to not cause conflicts with #344 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it much easier for wallets to add support for NWC, by not having to implement the lower-level NWC spec such as encrypting/decrypting and publishing events, subscribing to the relay etc.
TODOs: