Skip to content

Conversation

@getItemFromBlock
Copy link
Owner

Continuation of #16, moved in its own draft PR

@getItemFromBlock getItemFromBlock mentioned this pull request Jan 5, 2025
16 tasks
@SLimeyMC
Copy link

SLimeyMC commented Jan 24, 2025

I just got time to do this. Seems that you tried to rebase the new changes with this branch, but somehow managed to remove most of the things.

  1. I changed it to Kotlin gradle, you seem to have changed it. While I don't mind that, you're only doing it halfway and adding a lot of bandaids.
  2. I use the version catalog, you should use that or remove the TOML files.
  3. Forge build gradle lacked configuration for the Architectury, which is what caused it to fail to build I'm pretty sure.
  4. I'm pretty sure most of the points above happens because you use the wrong git command

So IMHO, the best course of action is. Close this branch create a new branch with the correct git command and gracefully resolve the conflict.

Anyhow, this is not draft PR; we are definitely going to do Fabric support lmao

@getItemFromBlock
Copy link
Owner Author

Hmm
I don't fully understand what happened, I probably didn't realize I was using the wrong option and the IDE switch in between didn't help. The changes to kotlin gradle were made by me trying to fix the errors by mostly looking at other mods, as the documentation I could find didn't seem to help. From what I have tested, there was already a build error in your last commit on your branch. Am I doing something wrong?
The new branch does not includes the last commit which seems to be the one that broke everything. It still has the same build error that I mentioned earlier, with the task :fabric:processResources
Here is the new PR, let me know if I also made something wrong here

Thanks for everything, and sorry for the inconvenience

@getItemFromBlock getItemFromBlock deleted the dev-1.18-architectury branch January 24, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants