Replace httpmock with wiremock#24
Open
fpierfed wants to merge 1 commit intogetaxonflow:mainfrom
Open
Conversation
…d crate async-std Signed-off-by: Francesco Pierfederici <fpierfed@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace httpmock with wiremock
Summary
Since httpmock (used in tests) depends on async-std which is unmaintained, better to replace it with wire mock which looks like it is in a better shape.
Test plan
N/A: same as before, just using a different mocking library.
cargo fmt --check cargo clippy --all-targets --all-features -- -D warnings cargo test --all-featuresContributor acknowledgement
git commit -s)CONTRIBUTING.md<branch>