Add static code analysis and make to test.yml#4
Open
Killpit wants to merge 31 commits intogetclave:mainfrom
Open
Add static code analysis and make to test.yml#4Killpit wants to merge 31 commits intogetclave:mainfrom
Killpit wants to merge 31 commits intogetclave:mainfrom
Conversation
getting up to date version of the contracts as there were updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Added Slither as static analysis tool to make sure that bugs and other potential vulnerabilities in the contracts being detected earlier in development
-Decided to add
--root packages/zksync-storage-contractstoforge test -vvvas the test.yml pipeline didn't work with the original command as it gave no tests to run, however, with using--rootcommand forforge test, the pipeline worked perfectly.