Support AWS Fargate execution #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczeles
requested review from
michalzelechowski-getindata and
em-pe
as code owners
szczeles
commented
Mar 30, 2022
| @@ -4,7 +4,7 @@ repos: | |||
| hooks: | |||
| - id: isort | |||
| - repo: https://github.com/psf/black | |||
| rev: stable | |||
| rev: 22.3.0 | |||
mwiewior
reviewed
Apr 11, 2022
|
@mwiewior That's fine! Also, please keep in mind that unit tests are still missing, I'm going to add some in the day or two. |
|
@mwiewior Tests are ready |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi! What is missing so this can be merged? |
|
@marcelopio This execution method turned out to be terribly slow in Fargate - there is like 5 minutes overhead for every single Kedro node due to slow download/extraction of big images (and apparently no images caching). With very "linear" pipelines, it takes hours to execute... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of executing Kedro pipeline steps in AWS Fargate. No tests added yet 🙈
Keep in mind: