-
Notifications
You must be signed in to change notification settings - Fork 77
Fix rkeops v2 for CRAN submission and keops v2.3 usage #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gdurif
wants to merge
56
commits into
main
Choose a base branch
from
fix_rkeops_v2_keops_v2.3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,859
−2,244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g explicit functions when generating formulas for LazyTensor
…hon requirement management
… setup) + minor explanation about reticulate usage
…onttest with dontshow chunk setting up environment and cleaning afterward) + minor code refactoring
…on doc generation
…eaning in the vignette
…us cache dir after running tests
…t CRAN submission)
… new cache directory to not exist and warn user
…pecific GPU usage) and disable long running tests by default (with a specific tag to activate them) for CRAN check
Contributor
Author
|
Note: only remaining TODO concerns re-enabling the CI check for rkeops (discussion in progress on the subject). The package needs to be checked on MacOS before CRAN submission. I can either try to re-enable the CI within this PR or we can merge this and I prepare another PR for re-enabling rkeops CI. |
This was referenced Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rkeopswas removed from CRAN because of bad cache directory management (CRAN policy violation).Following CRAN resubmission raised some issues about function documentation (man pages) that are automatically generated from
roxygen2in-line documentation:Current PR corresponds to the release of
rkeopsv2.3.0, which is ready for CRAN submission.reticulate(using the newpy_require()function)rkeopsv2.2.3 but now even better)