Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a significant increase in the loading time of my library (multipers) and tracing back the imports I ended up here.
The current issue is that if
torch_foundin the__init__.py, then the linewill trigger the
pykeops/torch/__init__.py, and loadtorch.If we want to have a lazy load of
torch, these functions thus need to be put outside thistorchfolder.In this PR, I propose to do a new hidden module
_test_install, and put thetest_{stuff}_bindingshere.I also put the
import torchinside the function to avoid importing it.