Open
Conversation
Fix getnikola#3865. Signed-off-by: Joshua Wise <joshua@joshuawise.com>
Contributor
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
| if self.strip_indexes and link[-(1 + index_len):] == '/' + self.index_file: | ||
| link = link[:-index_len] | ||
| if self.strip_extensions and link[-len(extension):] == extension: | ||
| link = link[:-len(extension)] |
Contributor
There was a problem hiding this comment.
While above you explicitly handle .html, here you handle general extensions. This doesn't fit together.
How about making STRIP_EXTENSIONS a list instead that provides a list of extensions that will be stripped? Then users can explicitly configure to strip .html but not .php, or both, or ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
This implements #3865 -- as seen in production on https://joshuawise.com/ .