fix: make codex send replays idempotent#131
Open
TheVortex8 wants to merge 5 commits intogetpaseo:mainfrom
Open
fix: make codex send replays idempotent#131TheVortex8 wants to merge 5 commits intogetpaseo:mainfrom
TheVortex8 wants to merge 5 commits intogetpaseo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_agent_message_requestidempotent when the same clientmessageIdis replayedmessageIdreuse with different text instead of silently starting a new runturn_startedevent was not observed firstRoot cause
On reconnect/replay paths, the daemon could accept the same logical user message twice because
messageIdwas only used for timeline recording, not run idempotency. That could start a second Codex run for the same message.The Codex app-server provider also buffered all pre-
turn_startedevents except permissions. If the replayed/resumed run surfaced only a terminal event (turn_completed,turn_failed, orturn_canceled), the provider ignored it and could leave the agent stuck inrunning.Testing
npx vitest run src/server/agent/providers/codex-app-server-agent.test.tsnpx vitest run src/server/daemon-e2e/send-message-id-replay.e2e.test.ts --maxWorkers=1 --minWorkers=1npm run typecheck --workspace=@getpaseo/server