fix: Remove workflow file updates from Craft release automation#112
Closed
fix: Remove workflow file updates from Craft release automation#112
Conversation
GitHub Apps cannot modify workflow files without 'workflows' permission, causing Craft releases to fail when trying to update _workflow_version defaults. The script now provides manual instructions instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Remove workflow file updates from Craft release automation ([#112](https://github.com/getsentry/github-workflows/pull/112))If none of the above apply, you can opt out of this check by adding |
Contributor
Author
|
replaced by #112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Craft release failure by removing automatic workflow file updates that require GitHub App
workflowspermission.Problem
The Craft release process failed with this error:
This happened because our PowerShell script tried to automatically update
_workflow_versiondefaults in workflow files during the release, but GitHub Apps don't haveworkflowspermission by default.Solution
_workflow_versiondefaults after releaseChanges
scripts/update-version.ps1to only display instructions instead of modifying workflow filesManual Process
After each release is published, manually update:
.github/workflows/updater.yml(line ~45).github/workflows/danger.yml(line ~9)Change the
defaultvalue from the old version to the new version.Test plan
🤖 Generated with Claude Code