ci(release): Switch from action-prepare-release to Craft#141
ci(release): Switch from action-prepare-release to Craft#141
Conversation
This PR migrates from the deprecated action-prepare-release to the new Craft GitHub Actions (reusable workflow or composite action). Changes: - Migrate .github/workflows/release.yml to Craft reusable workflow
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Build / dependencies / internal 🔧
🤖 This preview updates automatically when you update the PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The previous migration incorrectly removed the GitHub App token authentication step. This commit restores it by switching to the composite action pattern which preserves the auth flow.
| version: | ||
| description: Version to release | ||
| required: true | ||
| description: Version to release (or "auto") |
There was a problem hiding this comment.
Does this mean we need to type literal "auto" in the input? What version do we get then?
There was a problem hiding this comment.
To answer my own question...
it's automatically inferred form commits if not provided
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
|
||
| - name: Prepare release | ||
| uses: getsentry/action-prepare-release@v1 | ||
| uses: getsentry/craft@c6e2f04939b6ee67030588afbb5af76b127d8203 # v2 |
There was a problem hiding this comment.
According to the Craft documentation, there's a simpler reusable workflow approach available:
jobs:
release:
uses: getsentry/craft/.github/workflows/release.yml@v2
with:
version: ${{ inputs.version }}
secrets: inherit
Is there a reason not to use the reusable workflow pattern for releases as well?
|
replaced by #148 to address the comments & remove the unrelated switch to show changelog preview |
2 participants
Summary
This PR migrates from the deprecated
action-prepare-releaseto the new Craft GitHub Actions.Changes
.github/workflows/release.ymlto Craft reusable workflowDocumentation
See https://getsentry.github.io/craft/github-actions/ for more information.