Closed
Conversation
vaind
requested changes
Aug 11, 2025
Contributor
vaind
left a comment
vaind
left a comment
There was a problem hiding this comment.
I'm marking as request-changes just to block this. We need to land env vars properly in another PR
| INPUT_PATTERN: ${{ inputs.pattern }} | ||
| run: "$env:RUNNER_TEMP/ghwf/updater/scripts/update-dependency.ps1" -Path "$env:INPUT_PATH" -Pattern "$env:INPUT_PATTERN" | ||
| run: | | ||
| & "$env:RUNNER_TEMP/ghwf/updater/scripts/update-dependency.ps1" -Path "$env:INPUT_PATH" -Pattern "$env:INPUT_PATTERN" |
Contributor
There was a problem hiding this comment.
& evaluates the expression so it beats the purpose of the whole env var thing as a protection against code injection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses minor errors that show up when using
updater.yml.Example error: https://github.com/getsentry/sentry-unreal/actions/runs/16870254170