fix(spanv2): Indexed rate limits should not drop metric payloads #5464
+180
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/spans-total-indexed-ratelimtis
branch
2 times, most recently
from
8038aff to
6c71ffd
Compare
Dav1dde
force-pushed
the
dav1d/spans-total-indexed-ratelimtis
branch
from
6c71ffd to
bb94f33
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/spans-total-indexed-ratelimtis
branch
from
bb94f33 to
3a5ff60
Compare
loewenheim
approved these changes
Dec 10, 2025
Dav1dde
force-pushed
the
dav1d/spans-total-indexed-ratelimtis
branch
from
8c4705c to
809aa1d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of indexed rate limits, we still need to keep the total counts (metrics) alive. This fixes a bug in the SpanV2 rate limiting which would drop the entire payload when there was an indexed rate limit active.
Closes: INGEST-651