Open
Conversation
markstory
reviewed
Oct 26, 2022
Comment on lines
+267
to
+270
| This means that from a user's point of view the individual groups still exist, but the main way to | ||
| interact with them would be larger groups that group around the already existing smaller groups. | ||
| Since the events stay associated with their fingerprint created group the event itself is immutable | ||
| and stays that way, but the merge just becomes an association of that group with the supergroup. |
Member
There was a problem hiding this comment.
How do you see supergroups being represented in the datamodel? Are they an issue made of other 'similiar' issues?
Contributor
Author
There was a problem hiding this comment.
@markstory i think supergroups might be just a special case of a re-built merge where merges are multiple hashes being associated to a group by some mutable mechanism. The difference between a merge and a supergroup in that sense is, that a supergroup carries additional metadata that gives the merge some meaning.
There is some related thinking happening here: #30
Co-authored-by: Mark Story <mark@mark-story.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RFC describes supergroups. This is the new location of an earlier document. Supergroups are a second order container that summarizes and groups issues together by common root cause. Where the first order group are events with the same fingerprint, a supergroup is a group of multiple issues that share the same root cause even if they might not contain exactly the same stack trace.
Rendered RFC