rfc(feature): Aligning the Span Schema with OpenTelemetry#89
Closed
AbhiPrasad wants to merge 2 commits intomainfrom
Closed
rfc(feature): Aligning the Span Schema with OpenTelemetry#89AbhiPrasad wants to merge 2 commits intomainfrom
AbhiPrasad wants to merge 2 commits intomainfrom
Conversation
AbhiPrasad
force-pushed
the
rfc/aligning-the-span-schema-with-open-telemetry
branch
from
d3ed555 to
e0081b6
Compare
This was referenced Jul 11, 2023
Member
|
@AbhiPrasad, can you maybe add a comment on why you closed this RFC, please? |
Contributor
Author
|
This RFC draft is getting superceded with #101 - which should address the schema problems in a more holistic manner (looking at getters/setters on the span/transaction classes). |
Member
|
Thanks @AbhiPrasad 🙏. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #83.
Rendered RFC