feat: Auto-install distribution dependency when enabled for variant #1001
Conversation
runningcode
requested review from
adinauer,
chromy,
lcian,
markushi,
rbro112,
romtsn and
stefanosiano
as code owners
|
| ): TaskProvider<GenerateDistributionPropertiesTask>? { | ||
| val variantName = name | ||
| if (extension.distribution.enabledVariants.get().contains(variantName)) { | ||
| // Add the build distribution dependency if autoInstallation is enabled |
There was a problem hiding this comment.
I see all the machinery in plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/AutoInstall.kt & plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/*/*Strategy.kt
I assume we don't want to use that because we want to condition on extension.distribution.enabledVariants? It might be worth a comment either here and/or in plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/AutoInstall.kt explaining why distribution has a different implementation to the others
There was a problem hiding this comment.
Yes that was my thought, it’s just easier to include it in here although it does make the task do two things instead of one. I’ll add a comment.
| content { | ||
| includeGroup("com.android.tools") | ||
| } | ||
| content { includeGroup("com.android.tools") } |
There was a problem hiding this comment.
You ran some linter/formatter over this and/or sentry-java right as a big one off change before right? We should try get whatever you used added to the CI.
There was a problem hiding this comment.
this is weird. i just ran spotlessApply and it did this.
There was a problem hiding this comment.
I think have a theory: We run spotless on all the modules but perhaps we don’t call spotlessCheck on the root project. I will open a separate PR once I investigate further.
When a variant has distribution enabled and autoInstallation is true, automatically add sentry-android-distribution dependency to that variant. Refs: EME-278 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add comments explaining why sentry-android-distribution uses a custom auto-install implementation instead of the standard InstallStrategy approach. Distribution requires variant-specific installation based on extension.distribution.enabledVariants, whereas other integrations are installed globally when their dependencies are detected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
runningcode
force-pushed
the
no/auto-install-distribution-dependency
branch
from
92155d7 to
7e74c6a
Compare
3 participants
Summary
When build distribution is enabled for a variant (via
distribution.enabledVariants) andautoInstallation.enabled = true, the plugin now automatically adds thesentry-android-distributiondependency to that specific variant.Note: the library is only released as an alpha 8.24.0-alpha.1. You'll need to set
sentry.autoInstallation.sentryVersion="8.24.0-alpha.1"for this to work.Changes
SENTRY_ANDROID_DISTRIBUTIONmodule toSentryModulesconfigureDistributionPropertiesTaskto add the distribution dependency per variant when both distribution and autoInstallation are enabledRefs: EME-278
#skip-changelog as this is part of the unreleased build distribution feature
🤖 Generated with Claude Code