Add GenerateDistributionPropertiesTask for distribution options #999
+165
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements EME-397 by adding a Gradle task to generate distribution properties that will be bundled into the app and read by the SDK. The task generates sentry-distribution.properties with: - io.sentry.distribution.org-slug - io.sentry.distribution.project-slug - io.sentry.distribution.org-auth-token - io.sentry.distribution.build-configuration Values are sourced from the existing SentryPluginExtension (org, projectName, authToken) and the variant's build type. The task only runs for variants enabled in distribution.enabledVariants. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Make task cacheable and use @OutputFile annotation - Simplify task by removing unnecessary directory creation and logging - Use variant name as build configuration instead of just build type - Reorder register() parameters for consistency - Remove redundant tests that don't add coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
runningcode
requested review from
markushi,
romtsn,
adinauer,
stefanosiano,
lcian,
chromy and
rbro112
as code owners
chromy
approved these changes
Oct 7, 2025
...n-build/src/main/kotlin/io/sentry/android/gradle/tasks/GenerateDistributionPropertiesTask.kt
Outdated
Show resolved
Hide resolved
...n-build/src/main/kotlin/io/sentry/android/gradle/tasks/GenerateDistributionPropertiesTask.kt
Show resolved
Hide resolved
romtsn
reviewed
Oct 7, 2025
| ) { task -> | ||
| task.output.set(output) | ||
| task.withSentryTelemetry(extension, sentryTelemetryProvider) | ||
| // TODO we should check if the org and project are available in sentry.properties |
There was a problem hiding this comment.
oh yeah, this is a good point! We also check ext for org and project names, but I'm not sure if anyone is really using extras to set that. Maybe we should get rid of it in the upcoming major altogether
romtsn
reviewed
Oct 7, 2025
| task.orgSlug.set(extension.org) | ||
| task.projectSlug.set(extension.projectName) | ||
| // TODO we should have a separate authToken for Build Distribution | ||
| task.orgAuthToken.set(extension.authToken) |
There was a problem hiding this comment.
I guess it's more of a security topic, but idk if it's fine to inject and expose the auth token at runtime, given that we recommend hiding it in an env variable even on CI, for example.
romtsn
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements EME-397 by adding support for setting
SentryOptions.DistributionOptionsfrom Gradle using the existing properties file mechanism. There are probably many ways of passing these options to the client but using properties files doesn't require the client to recompile resources or code and there is already an existing mechanism in the codebase to do this so I just piggy-backed on that mechanism.This PR adds a
GenerateDistributionPropertiesTaskthat generates distribution-related properties which are bundled intosentry-debug-meta.propertiesand read by the SDK at runtime.Example Usage
#skip-changelog since this is for an unreleased feature that isn’t complete yet
Sentry-java
The sentry-java PR that implements this is here: getsentry/sentry-java#4784
🤖 Generated with Claude Code