-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(replay): Refactor pages inside the Product Walkthrough > Replay area #14712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 14.11kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-edge-server-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs say: use middleware.ts for simple (non-regexp) redirects
https://docs.sentry.io/contributing/pages/redirects/#add-a-new-redirect-in-middlewarets-recommended
85edb6e
to
9b7505e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for addressing one of my biggest gripes with the session replay docs!!!!
there's work to do on consistent formatting imo, but this is great <3
@@ -11,22 +11,22 @@ You can search for or browse replays of user sessions on the **Replay** page, wh | |||
- **Project**: The project in which the session was recorded. | |||
- **Start Time**: How long ago the replay was triggered. (Replays can appear here while the recording is still in progress.) | |||
- **Duration**: The length of the replay. (Recordings can range from 1 second to 60 minutes.) | |||
- **Errors:** The number of frontend errors identified by Sentry, as encountered in the replay. (Sometimes the error count reported is different from the actual errors captured. Read more in [Error Linking](/platforms/javascript/session-replay/#error-linking).) | |||
- **Errors:** The number of frontend errors identified by Sentry, as encountered in the replay. (Sometimes the error count reported is different from the actual errors captured. Read more in [Error Linking](/platform-redirect/?next=/session-replay/#error-linking).) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link takes me to an odd view in the Vercel preview... I see a shortlist of SDKs (not even comprehensive to everything Replay covers) and then then that goes to a generic Replay docs page?
What is the Error Linking link supposed to be? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it's a special platform re-direct, I'm assuming the missing platforms don't have the relevant section in their own docs, so that's OK.
Clicking on a platform link in the list, doesn't take me to Error Linking tho :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll look at making this link respect the #error-linking
but that'll be in another PR because the link is more of a core-component.
992642d
to
9f1b7b5
Compare
- **User Inputs:** except password fields which are always redacted. | ||
- **Navigations, Page Loads & View Changes:** [Learn more about spans](/product/sentry-basics/distributed-tracing/) | ||
- **Mobile specific:** Backgrounding and Foregrounding, Network connectivity and battery usage | ||
- **Web Vitals:** With links to [Web Vitals Insights](/product/insights/web-vitals/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we list out the vitals instead? and web vitals URL could be behind a "Learn more."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to be:
- Web Vitals: and an overall Performance Score Learn more
docs/product/explore/session-replay/replay-page-and-filters.mdx
Outdated
Show resolved
Hide resolved
docs/product/explore/session-replay/replay-page-and-filters.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jasmin <77064737+jas-kas@users.noreply.github.com> Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
docs/product/explore/session-replay/replay-page-and-filters.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
Inside
/product/explore/session-replay/
i noticed we had sort of two paths for users to follow: web or mobile. There was a lot of the same information in each side, but they were not structured in the same way.So i tried to merge things together where it makes sense, and keep the web vs. mobile split for as few things as possible.
The big change is that mobile doesn't have it's own
## Replay Details
section anymore. Andreplay-details.mdx
is less web-specific.Now we have:
Replays Page and Filters
docsReplays Details
docsReplay for Web
page with "What is Replay", "Supported SDKs", "Backend Errors" sections, performance sub-pageReplay for Mobile
page with "What is Replay", "Supported SDKs", "Backend Errors" sections (also FAQ), performance sub-page