-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(docs): Remove hard-coded domains from URLs where applicable across all documentation #14726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 25.03kB (0.11%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
scripts/remove_sentry_domain.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long term this'd be cool to convert into a lint rule, wired up like the https://github.com/getsentry/sentry-docs/blob/830bbc86fedd9c8461436946c2cf63246a6ad7cc/scripts/lint-404s/main.ts script.
But someone can do that in a followup PR. Short term i don't think we need to let that kind of thing slow down what's really a great #quickwin!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This will make the preview experience much smoother.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🥇
TBH I don't think we really need to commit the entire script but maybe we can reuse parts of it for a GH action. We could only let this run on the diff of every PR, less expensive this way - leaving this up to @sergical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have set aside some time to take a look at our 404 action, i will see what's the best usecase for this script/lint rule at that point as well, this is a huge win for now though, thank you @jas-kas!
No description provided.