docs(feature-flag): add documentation for php feature flags #15443
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| ```php | ||
| \Sentry\addFeatureFlag('test-flag', false); | ||
|
|
||
| captureException(new \RuntimeException("Something went wrong!")); |
There was a problem hiding this comment.
Bug: The PHP example calls captureException() without a namespace or use statement, leading to a fatal error if copied directly.
Severity: CRITICAL | Confidence: 0.95
🔍 Detailed Analysis
The PHP example for feature flags calls captureException() without a namespace prefix or a use statement. If a user copies this code into a PHP environment without use function Sentry\captureException;, it will result in a Fatal Error: Call to undefined function captureException(), causing the application to terminate.
💡 Suggested Fix
Prefix captureException() with the \Sentry\ namespace, changing captureException(new \RuntimeException("Something went wrong!")); to \Sentry\captureException(new \RuntimeException("Something went wrong!")); for consistency with other examples.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: platform-includes/feature-flags/evaluation-tracking-index/php.mdx#L7
Potential issue: The PHP example for feature flags calls `captureException()` without a
namespace prefix or a `use` statement. If a user copies this code into a PHP environment
without `use function Sentry\captureException;`, it will result in a Fatal Error: Call
to undefined function `captureException()`, causing the application to terminate.
Did we get this right? 👍 / 👎 to inform future reviews.
Bundle ReportChanges will increase total bundle size by 331.67kB (1.43%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| @@ -0,0 +1,10 @@ | |||
| ### Generic API | |||
| You can use the generic API to manually track feature flag evaluations. These evaluations are held in memory and are sent to Sentry on error and transaction events. **At the moment, we only support boolean flag evaluations.** | |||
There was a problem hiding this comment.
We might want to call out how many feature flags you can set.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES