fix: Sessions not getting finished#2895
Merged
bruno-garcia merged 3 commits intomainfrom Nov 23, 2023
Merged
Conversation
bitsandfoxes
changed the title
bruno-garcia
approved these changes
Nov 23, 2023
Member
|
We could probably benefit some integration tests eventually. But a fix should go out asap for this |
This was referenced Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2863 and #2551
With #2496 we moved updating the session to the
clientto be able to align with the rest of the SDKs regarding the order of filtering and whether dropped events affect the session.But we forgot to pass the
GlobalSessionManagerfrom thehubto theclient. So both thehuband theclienthad their ownGlobalSessionManager.Ideally, I'd like to fix this properly by keeping the SessionManager solely on the
huband passing the session at the time down to the scope during capture instead of holding the state in the client. But with getsentry/rfcs#122 on the horizon, this might be a waste of time and effort.