feat: native signal handler strategy on Android#4676
Draft
Conversation
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4676 +/- ##
==========================================
+ Coverage 73.85% 76.36% +2.51%
==========================================
Files 483 435 -48
Lines 17578 15952 -1626
Branches 3464 3189 -275
==========================================
- Hits 12982 12182 -800
+ Misses 3742 3018 -724
+ Partials 854 752 -102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Oct 27, 2025
Collaborator
Author
|
@jamescrosswell This is marked as a draft because it's still waiting for dependencies, but we could already kick off the review process if you have time. :) Do you have a preferred approach for exposing this as an opt-in API? The current proposal mirrors the sentry-native enum. #if ANDROID
options.Native.SignalHandlerStrategy = Sentry.Android.SignalHandlerStrategy.ChainAtStart;
#endifWith only two values, a simple boolean flag could also work for the time being, but I'm unsure if potential Android Tombstone support could change things in the future. |
jpnurmi
force-pushed
the
feat/android-signal-handler-strategy
branch
from
af57caa to
4486918
Compare
jpnurmi
force-pushed
the
feat/android-signal-handler-strategy
branch
from
4486918 to
7a489eb
Compare
jpnurmi
force-pushed
the
feat/android-signal-handler-strategy
branch
from
7a489eb to
543b3e3
Compare
Collaborator
Author
|
Update: I'll get back to this after #4750 to make sure this works with .NET 10 |
…-handler-strategy
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Dependencies ⬆️Deps
Test
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in, Android-only solution for:
According to our newly introduced Android integration tests, getsentry/sentry-native#1392 works on
android-arm64andandroid-x64in bothReleaseandDebugconfigurations, but we'd like to validate the fix further in real-world conditions. To that end, we're making it opt-in initially so customers can try it on more devices, platforms, and configurations before considering it as the new default.Note
Depends on: