Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/danger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ on:

jobs:
danger:
uses: getsentry/github-workflows/.github/workflows/danger.yml@v2
uses: getsentry/github-workflows/.github/workflows/danger.yml@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow Syntax Error After Update

The danger workflow was updated to v3 of getsentry/github-workflows, which is now a composite action. The current job-level uses: syntax is for reusable workflows and doesn't align with the composite action format, which expects runs-on: ubuntu-latest and steps:. This syntax mismatch will cause the workflow to fail.

Fix in Cursor Fix in Web

4 changes: 2 additions & 2 deletions .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
native:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-sentry-native-ndk.sh
name: Native SDK
Expand All @@ -20,7 +20,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

gradle-wrapper:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow Syntax Mismatch Causes Failures

The updater and danger workflows were upgraded to v3 but still use the v2 reusable workflow syntax. v3 actions are now composite actions, requiring runs-on: ubuntu-latest, steps:, and a direct action path. This will cause workflow failures. Additionally, v3 of the updater action changed the default pr-strategy from create to update, which may alter PR creation behavior.

Additional Locations (1)

Fix in Cursor Fix in Web

with:
path: scripts/update-gradle.sh
name: Gradle
Expand Down
Loading