chore(publish): Use workspaces option in Craft NPM target#855
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
4372dc1 to
d855927
Compare
andreiborza
left a comment
There was a problem hiding this comment.
dumb question: do we then still need includeNames and the tarballs specified in requireNames?
Good question, I'm not sure actually! @BYK can we remove them safely? I think it doesn't hurt having them but if they're no longer necessary, happy to remove them. |
|
You'd probably need
|
Makes use of craft's new feature to detect npm packages in topological order. This makes our publishing process slightly more robust since previously, we didn't specify an explicit order. This is also a trial run for the sentry-javascript repo, so that we can test the craft option on a smaller monorepo like this one.