Draft
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Other
🤖 This preview updates automatically when you update the PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const ms = new MagicString(code, { filename: chunk.fileName }); | ||
|
|
||
| const match = code.match(COMMENT_USE_STRICT_REGEX)?.[0]; |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had this stashed and thought I may as well open a PR so this code doesn't die on my laptop!
Should we do this?
Personally I think we should migrate away from unplugin because:
This PR drops using Unplugin for Rollup and instead just exports a single Rollup plugin that handles everything. For Vite we can just re-export the Rollup plugin with an additional wrapper.
Downsides?
If we add support for hook filters (#749), we would actually want the transforms to be contained in their own plugins because they would each need different regex filters for the best performance.