-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(cloudflare): Add integration test infrastructure #16848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…m:getsentry/sentry-javascript into timfish/test/cloudflare-integration-tests
completed: async function (): Promise<void> { | ||
return isComplete; | ||
}, | ||
makeRequest: async function <T>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, maybe it could be possible to have a WS method also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I guess we'll add more options when we add tests that need it!
@timfish is this ready to review? |
Yes! |
I tried using
cloudflare:test
and the wrangler vitest pool but with the config it doesn't appear like there's an easy way to have more than one wrangler config. This isn't very useful if you want to add lots of different tests with different wrangler configurations!After much frustration and attempts I decided to just copy the Node integration test runner and strip out all the stuff we didn't need. This took less time than I'd already spend messing around. I debated making the test runners use shared code but quickly discounted that because of how little actually ends up being shared.
This PR:
createBasicSentryServer
from the Node integration test to@sentry-internal/test-utils
so it can be used by bothdev-packages/cloudflare-integration-tests/
with all the basic files it needsspawn('wrangler', ['dev', '--config', wranglerConfigPath, '--var', 'SENTRY_DSN:${SENTRY_DSN}']);
fetch
handler which asserts the entire envelope