-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Apply scope attributes to logs #18184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Lms24
wants to merge
6
commits into
lms/feat-core-scope-setAttributes
Choose a base branch
from
lms/feat-core-logs-apply-scope-attributes
base: lms/feat-core-scope-setAttributes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(core): Apply scope attributes to logs #18184
Lms24
wants to merge
6
commits into
lms/feat-core-scope-setAttributes
from
lms/feat-core-logs-apply-scope-attributes
+431
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
52339f2 to
b97b3f4
Compare
a3e204d to
205752c
Compare
5053159 to
e5785ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, Based on #18165
TBD:
Log.attributestype to a similar object that users can pass intoscope.setAttribute(s)to define units. I'd rather do this in a follow-up PR.closes #18159