Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 12, 2025

WIP, Based on #18165

  • Unify attribute -> typed attribute conversion
  • Logs can now have array attributes
  • Apply scope attributes to logs

TBD:

  • permitting units requires extending the Log.attributes type to a similar object that users can pass into scope.setAttribute(s) to define units. I'd rather do this in a follow-up PR.

closes #18159

@Lms24 Lms24 changed the base branch from develop to lms/feat-core-scope-setAttributes November 12, 2025 11:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.71 kB added added
@sentry/browser - with treeshaking flags 23.22 kB added added
@sentry/browser (incl. Tracing) 41.46 kB added added
@sentry/browser (incl. Tracing, Profiling) 45.78 kB added added
@sentry/browser (incl. Tracing, Replay) 79.92 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.62 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 84.6 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 96.82 kB added added
@sentry/browser (incl. Feedback) 41.39 kB added added
@sentry/browser (incl. sendFeedback) 29.39 kB added added
@sentry/browser (incl. FeedbackAsync) 34.31 kB added added
@sentry/react 26.41 kB added added
@sentry/react (incl. Tracing) 43.42 kB added added
@sentry/vue 29.2 kB added added
@sentry/vue (incl. Tracing) 43.26 kB added added
@sentry/svelte 24.73 kB added added
CDN Bundle 27.03 kB added added
CDN Bundle (incl. Tracing) 42.01 kB added added
CDN Bundle (incl. Tracing, Replay) 78.57 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 84.03 kB added added
CDN Bundle - uncompressed 79.23 kB added added
CDN Bundle (incl. Tracing) - uncompressed 124.61 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 240.64 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 253.41 kB added added
@sentry/nextjs (client) 45.85 kB added added
@sentry/sveltekit (client) 41.85 kB added added
@sentry/node-core 51 kB added added
@sentry/node 159.31 kB added added
@sentry/node - without tracing 92.89 kB added added
@sentry/aws-serverless 106.62 kB added added

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 11,076 - - added
GET With Sentry 1,676 15% - added
GET With Sentry (error only) 7,795 70% - added
POST Baseline 1,190 - - added
POST With Sentry 571 48% - added
POST With Sentry (error only) 1,062 89% - added
MYSQL Baseline 3,888 - - added
MYSQL With Sentry 516 13% - added
MYSQL With Sentry (error only) 3,321 85% - added

@Lms24 Lms24 force-pushed the lms/feat-core-logs-apply-scope-attributes branch 2 times, most recently from 52339f2 to b97b3f4 Compare November 18, 2025 12:15
@Lms24 Lms24 force-pushed the lms/feat-core-scope-setAttributes branch 2 times, most recently from a3e204d to 205752c Compare November 18, 2025 16:51
@Lms24 Lms24 force-pushed the lms/feat-core-logs-apply-scope-attributes branch from 5053159 to e5785ea Compare November 18, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants