Skip to content

ci: Test against PHP 8.5 #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ci: Test against PHP 8.5 #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67676a
Test against PHP 8.5
jnoordsij Oct 1, 2025
4b510bf
Disable no-op calls to setAccessible for PHP < 8.1 in tests
jnoordsij Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ "8.4", "8.3", "8.2", "8.1" ]
php: [ "8.5", "8.4", "8.3", "8.2", "8.1" ]
packages:
# All versions below only support PHP ^8.1 (Laravel requirement)
- { laravel: ^10.0, testbench: ^8.0, phpunit: 9.6.* }
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ "8.4", "8.3", "8.2", "8.1", "8.0", "7.4", "7.3", "7.2" ]
php: [ "8.5", "8.4", "8.3", "8.2", "8.1", "8.0", "7.4", "7.3", "7.2" ]
packages:
# All versions below should be test on PHP ^7.1 (Sentry SDK requirement) and PHP < 8.0 (PHPUnit requirement)
- { laravel: ^6.0, testbench: 4.7.*, phpunit: 8.4.* }
Expand Down Expand Up @@ -136,6 +136,13 @@ jobs:
- php: "8.4"
packages: { laravel: ^8.0, testbench: ^6.0, phpunit: 9.3.* }

- php: "8.5"
packages: { laravel: ^6.0, testbench: 4.7.*, phpunit: 8.4.* }
- php: "8.5"
packages: { laravel: ^7.0, testbench: 5.1.*, phpunit: 8.4.* }
- php: "8.5"
packages: { laravel: ^8.0, testbench: ^6.0, phpunit: 9.3.* }

name: phpunit (PHP:${{ matrix.php }}, Laravel:${{ matrix.packages.laravel }})

steps:
Expand Down
12 changes: 10 additions & 2 deletions test/Sentry/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ protected function getCurrentSentryScope(): Scope
$hub = $this->getSentryHubFromContainer();

$method = new ReflectionMethod($hub, 'getScope');
$method->setAccessible(true);
if (\PHP_VERSION_ID < 80100)
{
// This method is no-op starting from PHP 8.1; see also https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible
$method->setAccessible(true);
}

return $method->invoke($hub);
}
Expand All @@ -136,7 +140,11 @@ protected function getCurrentSentryBreadcrumbs(): array
$scope = $this->getCurrentSentryScope();

$property = new ReflectionProperty($scope, 'breadcrumbs');
$property->setAccessible(true);
if (\PHP_VERSION_ID < 80100)
{
// This method is no-op starting from PHP 8.1; see also https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible
$property->setAccessible(true);
}

return $property->getValue($scope);
}
Expand Down
Loading