Do not overwrite existing baggage on outgoing requests#2191
Merged
sentrivana merged 15 commits intomasterfrom Jun 27, 2023
Merged
Do not overwrite existing baggage on outgoing requests#2191sentrivana merged 15 commits intomasterfrom
sentrivana merged 15 commits intomasterfrom
Conversation
Contributor
Author
|
Note to self: the aiohttp-as-client integration will probably need this, too. |
antonpirker
approved these changes
Jun 23, 2023
sentrivana
commented
Jun 23, 2023
sentrivana
commented
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's custom data in the
baggageheader of an outgoing request, we should preserve it when adding our custom sentry tracing baggage items.Closes #2190