Skip to content

Make DedupeIntegration more memory efficient. #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Make DedupeIntegration more memory efficient. #4446

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aaa78c4
store a hash of the exc instead of full exc
antonpirker Jun 5, 2025
549fae8
getting the full stacktrace
antonpirker Jun 5, 2025
3d66381
trying with an hash of the event stacktrace
antonpirker Jun 5, 2025
c8b8be4
Hashing just the important parts of the event
antonpirker Jun 5, 2025
b815c2c
resilience
antonpirker Jun 5, 2025
480c2d7
using id()
antonpirker Jun 5, 2025
cd0985a
cleanup
antonpirker Jun 5, 2025
d328fda
better readability
antonpirker Jun 5, 2025
07ca266
removed changes made to test.
antonpirker Jun 6, 2025
bdd0d7d
Merge branch 'master' into antonpirker/make-dedupe-integration-more-m…
antonpirker Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sentry_sdk/integrations/dedupe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ def processor(event, hint):
if exc_info is None:
return event

exc = exc_info[1]
if integration._last_seen.get(None) is exc:
exc_id = id(exc_info[1])
if integration._last_seen.get(None) == exc_id:
return None
integration._last_seen.set(exc)

integration._last_seen.set(exc_id)
return event

@staticmethod
Expand Down
Loading