feat(langchain): Support BaseCallbackManager
#4486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4486 +/- ##
==========================================
- Coverage 80.76% 80.68% -0.08%
==========================================
Files 156 156
Lines 16483 16496 +13
Branches 2801 2806 +5
==========================================
- Hits 13312 13310 -2
- Misses 2290 2303 +13
- Partials 881 883 +2
|
Base automatically changed from
szokeasaurusrex/refactor-langchain-args
to
master
June 24, 2025 12:37
szokeasaurusrex
force-pushed
the
szokeasaurusrex/langchain-support-manager
branch
3 times, most recently
from
a2a6b6f to
beec36c
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/langchain-support-manager
branch
from
beec36c to
d7efd46
Compare
sentrivana
approved these changes
Jun 30, 2025
sentry_sdk/integrations/langchain.py
Outdated
| integration.tiktoken_encoding_name, | ||
| ), | ||
| ] | ||
| local_callbacks = local_callbacks_with_sentry() |
There was a problem hiding this comment.
This function-based approach seems a bit complicated. It took me longer to parse than necessary.
I'd prefer we got rid of the local_callbacks_with_sentry functions altogether and move/inline the logic here to keep it simple.
While implementing #4479, I noticed that our Langchain integration lacks support for the `local_callbacks` having type `BaseCallbackManager`, which according to the type hint is possible. This change adds support for this case.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/langchain-support-manager
branch
from
d7efd46 to
048c148
Compare
szokeasaurusrex
commented
Jul 15, 2025
There was a problem hiding this comment.
Thanks for adding! Looks ok but would prefer we simplify a bit, see comment
Made this change, would appreciate if you can take a second look @sentrivana
sentrivana
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #4479, I noticed that our Langchain integration lacks support for the
local_callbackshaving typeBaseCallbackManager, which according to the type hint is possible.This change adds support for this case.
Fixes #4537
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval.