feat(sentry-core): Implement trace metric capture batching#1026
Draft
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/metrics-protocolfrom
Draft
feat(sentry-core): Implement trace metric capture batching#1026szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/metrics-protocolfrom
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/metrics-protocolfrom
Conversation
|
szokeasaurusrex
force-pushed
the
szokeasaurusrex/core-metrics-capture
branch
from
fed0741 to
1182de0
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 9, 2026
Basic metrics capture functionality. Follow-up PR will implement the rest. Closes #1023 Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/core-metrics-capture
branch
from
1182de0 to
5a88567
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 9, 2026
Basic metrics capture functionality. Follow-up PR will implement the rest. Closes #1023 Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/core-metrics-capture
branch
from
5a88567 to
e3ba50e
Compare
lcian
reviewed
Mar 10, 2026
lcian
reviewed
Mar 10, 2026
sentry-core/src/clientoptions.rs
Outdated
Comment on lines
+175
to
+177
| /// Determines whether captured trace metrics should be sent to Sentry (defaults to true). | ||
| #[cfg(feature = "metrics")] | ||
| pub enable_metrics: bool, |
Member
There was a problem hiding this comment.
So our intention here is for the users to explicitly opt in by adding both the feature flag and specifying enable_metrics: true. Right?
Suggested change
| /// Determines whether captured trace metrics should be sent to Sentry (defaults to true). | |
| #[cfg(feature = "metrics")] | |
| pub enable_metrics: bool, | |
| /// Determines whether captured trace metrics should be sent to Sentry (defaults to false). | |
| #[cfg(feature = "metrics")] | |
| pub enable_metrics: bool, |
lcian
reviewed
Mar 10, 2026
szokeasaurusrex
force-pushed
the
szokeasaurusrex/metrics-protocol
branch
3 times, most recently
from
da1a44c to
d6d3ba8
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 16, 2026
Basic metrics capture functionality. Follow-up PR will implement the rest. Closes #1023 Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/core-metrics-capture
branch
from
e3ba50e to
edc47d5
Compare
Basic metrics capture functionality. Follow-up PR will implement the rest. Closes #1023 Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/core-metrics-capture
branch
from
edc47d5 to
a16e498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic metrics capture functionality. Follow-up PR will implement the rest.
Closes #1023
Closes RUST-168