feat: Added Cysharp and DG.Tweening to InAppExclude
#2285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Missing changelog? |
bitsandfoxes
requested review from
limbonaut,
tustanivsky,
vaind,
mujacica and
a team
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Comment on lines
+324
to
+325
| AddInAppExclude("Cysharp"); | ||
| AddInAppExclude("DG.Tweening"); |
There was a problem hiding this comment.
The hardcoded exclusions for third-party libraries may not be ideal for all use cases. Consider providing a configuration option to allow users to opt-out of these automatic exclusions if they need to debug issues within these libraries. This could be implemented as a boolean property like ExcludeCommonThirdPartyLibraries with a default value of true to maintain the current behavior while allowing flexibility for advanced users.
Suggested change
| AddInAppExclude("Cysharp"); | |
| AddInAppExclude("DG.Tweening"); | |
| if (ExcludeCommonThirdPartyLibraries) | |
| { | |
| AddInAppExclude("Cysharp"); | |
| AddInAppExclude("DG.Tweening"); | |
| } |
Did we get this right? 👍 / 👎 to inform future reviews.
mujacica
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2269
The SDK should mark known third party tools and libraries to
InAppExcludeso that the stacktrace highlights the really relevant bits - the user's code.Cysharp
Before:
After:
DG.Tweening
Before:
After:
