Add traces sampling function support for Windows and Linux #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mujacica
reviewed
Aug 27, 2025
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentrySubsystem.cpp
Outdated
Show resolved
Hide resolved
| @@ -290,7 +346,7 @@ void FGenericPlatformSentrySubsystem::InitWithSettings(const USentrySettings* se | |||
| } | |||
| if (settings->EnableTracing && settings->SamplingType == ESentryTracesSamplingType::TracesSampler) | |||
| { | |||
| UE_LOG(LogSentrySdk, Warning, TEXT("The Native SDK doesn't currently support sampling functions")); | |||
| sentry_options_set_traces_sampler(options, HandleTraceSampling); | |||
There was a problem hiding this comment.
Can we make HandleTraceSampling non-static and forward "this" here. We could get rid of the static pointer to the class then?
There was a problem hiding this comment.
Unlike other Native SDK callbacks sentry_options_set_traces_sampler doesn’t provide a user_data parameter which normally acts as a closure allowing access to the subsystem implementation within the handler.
There was a problem hiding this comment.
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentrySubsystem.h
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jpnurmi
approved these changes
Aug 28, 2025
tustanivsky
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Aug 28, 2025
This PR updates `Sampling` section for Unreal SDK docs: - Removed notice that trace sampling function is not supported on Windows and Linux - Updated custom trace sampler example Related to: - getsentry/sentry-unreal#1057
tustanivsky
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Aug 29, 2025
This PR adds Unreal Engine SDK migration guide for the upcoming `1.0.0` plugin release. Related to: - getsentry/sentry-unreal#928 - getsentry/sentry-unreal#971 - getsentry/sentry-unreal#1051 - getsentry/sentry-unreal#1018 - getsentry/sentry-unreal#886 - getsentry/sentry-unreal#745 - getsentry/sentry-unreal#436 - getsentry/sentry-unreal#589 - getsentry/sentry-unreal#1057 - getsentry/sentry-unreal#669 --------- Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces traces sampling function support for platforms where the Unreal plugin relies on
sentry-native(enabled by getsentry/sentry-native#1108)Key changes:
FSentryTransactionOptionsstruct to hold custom sampling context (intended to be extended in future)USentrySubsystem::StartTransactionWithContextAndOptionsnow acceptsFSentryTransactionOptionsinstead ofTMap<FString, FString>FSentryVariantinstead ofFStringRelated docs update: