fix(releases): Fix new groups count per project for a release #100919
+380
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100919 +/- ##
===========================================
+ Coverage 80.69% 81.19% +0.50%
===========================================
Files 8626 8622 -4
Lines 382662 382563 -99
Branches 24036 24023 -13
===========================================
+ Hits 308774 310630 +1856
+ Misses 73556 71607 -1949
+ Partials 332 326 -6 |
|
@sentry review |
srest2021
changed the title
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
|
@sentry review |
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| release_id: [ | ||
| cast(SerializedProject, {**project_map[project_id], "newGroups": count}) | ||
| for project_id, count in mapping.items() | ||
| ] |
There was a problem hiding this comment.
Bug: Project List Incomplete and KeyError Risk
The release_projects_map is built by iterating over new_groups_map, which can cause projects without new groups to be omitted from the release's project list. This also introduces a KeyError risk if new_groups_map contains a project ID not found in the main project_map.
There was a problem hiding this comment.
I'm not totally certain how this behavior differs from the old behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the number of new groups per project for a certain release was incorrect - it showed the same number for all projects in a release. This is because we were using the per-project new groups count (ie, release.projects[x].newGroups), which was incorrectly returning the sum of all new group counts across all releases for that project.
In #99555 we switched to using release.newGroups. But this also incorrectly returns the total number of new issues across all projects for that release.
Here we fix the underlying issue with release.projects[x].newGroups by setting it to the new groups count for that release in that project. This fix only applies to the new serializer.