tests(alerts): Increase test coverage in incident chart test #100936
+35
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
commented
Oct 3, 2025
| class FetchOpenPeriodsTest(TestCase): | ||
| @freeze_time(frozen_time) | ||
| @patch("sentry.incidents.charts.client.get") | ||
| @with_feature("organizations:incidents") |
There was a problem hiding this comment.
Without this we were actually hitting a 404 hitting the incidents endpoint, but the test didn't care to check
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100936 +/- ##
========================================
Coverage 81.11% 81.12%
========================================
Files 8659 8659
Lines 384312 384312
Branches 24251 24251
========================================
+ Hits 311746 311759 +13
+ Misses 72222 72209 -13
Partials 344 344 |
ceorourke
force-pushed
the
ceorourke/incident-chart-test-coverage
branch
2 times, most recently
from
18aa429 to
fbc260e
Compare
ceorourke
force-pushed
the
ceorourke/incident-chart-test-coverage
branch
from
fbc260e to
f1f16e6
Compare
ceorourke
commented
Oct 7, 2025
| time_period = incident_date_range(60, incident.date_started, incident.date_closed) | ||
|
|
||
| fetch_metric_issue_open_periods(self.organization, detector.id, time_period) | ||
| mock_client_get.assert_called_with( |
There was a problem hiding this comment.
I recognize that I'm changing what's being tested here, but I'm not sure the previous test was adding much value. I can keep it around and add this as an additional test if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on https://getsentry.atlassian.net/browse/ACI-482 I was not able to find a test that asserted the output of
fetch_metric_issue_open_periods. Since I'll be changing the response I wanted a test to be able to compare against and this one only checked that it was called with the expected params.This is a little futile since we'll be moving away from this but it's helpful as a starting point.