Skip to content

Conversation

Buddhsen-tripathi
Copy link

Description

Improves the user experience of the CommitYamlPage by replacing a plain text placeholder with a proper empty state component.

Changes

  • Replaced plain <p> tag with EmptyStateWarning component
  • Added internationalization support using t() function
  • Improves visual consistency with other empty states across the application

Why

The previous implementation was just a plain text placeholder. This change provides:

  • Better visual hierarchy and styling
  • Consistency with Sentry's design patterns for empty states

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 4, 2025
cursor[bot]

This comment was marked as outdated.


import {space} from 'sentry/styles/space';

import {LayoutGap} from '../layout';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The code attempts to import LayoutGap from ../layout, but this module does not exist, which will cause a runtime error when the page loads.
  • Description: The CommitYamlPage component attempts to import LayoutGap from ../layout. However, the target file, static/app/views/prevent/coverage/layout.tsx, does not exist. This will cause a JavaScript module resolution error when the component is loaded, preventing the page from rendering entirely. Other components in the same directory define LayoutGap locally, indicating this was likely an incorrect refactoring attempt where the local definition was removed but the shared module was never created.

  • Suggested fix: Re-add the local definition of the LayoutGap styled component within commitYaml.tsx, similar to how it is implemented in other components in the same directory: const LayoutGap = styled('div')\display: grid; gap: ${space(2)};`;`.
    severity: 0.8, confidence: 1.0

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant