feat(seer-explorer): add rpc to fetch trace by id #100942
Open
+165
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100942 +/- ##
========================================
Coverage 81.14% 81.14%
========================================
Files 8629 8629
Lines 382754 382778 +24
Branches 24053 24053
========================================
+ Hits 310604 310624 +20
- Misses 71818 71822 +4
Partials 332 332 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| transaction_name=transaction_name, | ||
| total_spans=len(spans), | ||
| spans=spans, | ||
| ) |
There was a problem hiding this comment.
Bug: Inconsistent Trace Handling and KeyError
The get_trace_from_id function can return a TraceData object with an empty spans list if all rows lack a span_id after filtering, which is inconsistent with returning None when no spans are found initially. Separately, direct dictionary access for transaction and trace can raise a KeyError if these fields are missing from the first row, unlike other fields using .get().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of AIML-785: give agent tools to view traces by id