-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New Cloud Agent #103582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cursor
wants to merge
3
commits into
master
Choose a base branch
from
seerapierror-detailno-run-id-ot1tlk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New Cloud Agent #103582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jenn.muengtaweepongsa <jenn.muengtaweepongsa@sentry.io>
This change adds a `run_id` to the webhook URL for coding agent integrations. This allows the webhook handler to associate incoming events with a specific autofix run. Co-authored-by: jenn.muengtaweepongsa <jenn.muengtaweepongsa@sentry.io>
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
SeerApiError: {"detail":"No run_id found for agent_id..."}by gracefully handling Cursor webhook updates for agents not initiated by Sentry.Previously, Seer would return a 404 if an
agent_idfrom a Cursor webhook didn't map to an internal Autofixrun_id. This caused Sentry to log aSeerApiError(cursor_webhook.seer_update_error) for an expected external agent completion.This PR modifies
update_coding_agent_stateto:seer.autofix.coding_agent_state_not_registered) and returnFalsein this specific case, rather than raising aSeerApiError._update_coding_agent_status) now logscursor_webhook.agent_not_registeredat an informational level when Seer ignores the update.This change reduces noise in error tracking by treating these external agent completions as expected informational events instead of errors.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.