Skip to content

Increase task deadline to match rpc timeout #103588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Increase task deadline to match rpc timeout #103588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sentry/sentry_apps/tasks/sentry_apps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ def _webhook_issue_data(
name="sentry.sentry_apps.tasks.sentry_apps.send_alert_webhook_v2",
namespace=sentryapp_tasks,
retry=Retry(times=3, delay=60 * 5),
processing_deadline_duration=5,
# The task waits on cross-silo RPCs that have a 10s timeout, so give ourselves
# enough headroom to complete without tripping the worker deadline.
processing_deadline_duration=15,
silo_mode=SiloMode.REGION,
)
@retry_decorator
Expand Down
Loading