Sanitize oauth error parameter to prevent injection #103599
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jenn.muengtaweepongsa <jenn.muengtaweepongsa@sentry.io>
github-actions
bot
added
the
Scope: Backend
❌ 11 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an XSS vulnerability by hardening OAuth2 login and callback views to prevent the premature processing and rendering of untrusted
errorquery parameters.Previously, the presence of
code,error, orstatein the query parameters would immediately trigger callback logic, allowing a maliciouserrorparameter to be rendered unescaped without proper OAuth state validation.The changes ensure that:
stateparameter against the stored pipeline state before processing any other callback parameters, includingerror.stateis missing or mismatched, the pipeline immediately short-circuits with a generic validation error, preventing any untrustederrorpayloads from reaching the UI.errorparameter from the OAuth provider be considered, ensuring that any displayed errors originate from a trusted source.This prevents attackers from injecting and rendering arbitrary content via the
errorquery parameter.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.