feat: increase max_length for api tokens#65743
Merged
Conversation
Contributor
|
This PR has a migration; here is the generated SQL for --
-- Alter field refresh_token on apitoken
--
ALTER TABLE "sentry_apitoken" ALTER COLUMN "refresh_token" TYPE varchar(71);
--
-- Alter field token on apitoken
--
ALTER TABLE "sentry_apitoken" ALTER COLUMN "token" TYPE varchar(71); |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65743 +/- ##
===========================================
+ Coverage 58.51% 84.21% +25.69%
===========================================
Files 5086 5274 +188
Lines 224231 235949 +11718
Branches 38792 40859 +2067
===========================================
+ Hits 131206 198695 +67489
+ Misses 92801 37035 -55766
+ Partials 224 219 -5
|
wedamija
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In support of getsentry/rfcs#32.
API Tokens will be prefixed with seven extra characters (ex.
sntryu_). Eventually these plaintexttokencolumns will be dropped, but to maintain backwards compatibility and a smooth transition to fully hashed tokens we'll still want to store them here.