migration: backfill apitoken hashed values#71728
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
Contributor
|
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
mdtro
force-pushed
the
mdtro/backfill-apitoken-hashes
branch
from
e11d6c1 to
2532fb5
Compare
mdtro
force-pushed
the
mdtro/backfill-apitoken-hashes
branch
from
996b6a6 to
59e1022
Compare
mdtro
force-pushed
the
mdtro/backfill-apitoken-hashes
branch
from
59e1022 to
c3bc470
Compare
Contributor
|
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
wedamija
reviewed
Jun 4, 2024
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
This is looking good to me, just a couple of small comments to help make sure this migration doesn't break in the future
wedamija
approved these changes
Jun 4, 2024
mdtro
force-pushed
the
mdtro/backfill-apitoken-hashes
branch
from
248d63f to
c3f4410
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71728 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 6582 6582
Lines 293498 293498
Branches 50641 50641
=======================================
+ Hits 228900 228913 +13
+ Misses 58366 58351 -15
- Partials 6232 6234 +2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports getsentry/rfcs#32
We've been hashing tokens as they are used to authenticate (#65941), but it's started to level out. This is a backfill migration to fill in all of the hashed values for the remaining tokens.
Huge thank you to @markstory @wedamija and @GabeVillalobos for helping with the migration test! 🙏