Skip to content

ref(replay): Convert ReplayTable to use SimpleTable under the hood #94590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 1, 2025

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jun 27, 2025

There's some small small differences related to padding and stuff of the table rows, the header row is a bit different which makes column widths different.
Overall we're using the same table-cell implementation as before, so all the data rendering is the same.

Dropdowns also all moved to the right of the cells, no more shifting left/right depending on which column we're looking at:

Dropdown Example 1 Dropdown Example 2
SCR-20250627-ojly SCR-20250627-ojnh
Page Before After
Replay List SCR-20250627-ohpj SCR-20250627-ohxj
Issues -> Replay SCR-20250627-ohsv SCR-20250627-oibu
Transaction -> Replay SCR-20250627-ohva SCR-20250627-oide

Fixes REPLAY-460

@ryan953 ryan953 requested review from a team as code owners June 27, 2025 23:20
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 27, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jun 27, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10631 1 10630 9
View the top 1 failed test(s) by shortest run time
useReplayCount getOne & hasOne should return 0 if the data is loaded but does not include a count for a requested id
Stack Traces | 0.267s run time
Error: expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: undefined
    at Object.<anonymous> (.../utils/replayCount/useReplayCount.spec.tsx:85:45)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SDK Version Hardcoding Causes Search Issues

The error message displayed when searching for 'click' fields hardcodes the required SDK version as '7.44.0'. This should instead use the MIN_REPLAY_CLICK_SDK.minVersion constant to ensure the displayed version matches the actual requirement and updates automatically.

static/app/views/replays/table/replayIndexTable.tsx#L86-L88

field: <strong>'click'</strong>,
sdkPrompt: <strong>{t('SDK version >= 7.44.0')}</strong>,
})}

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work as expected!

@ryan953 ryan953 merged commit e73096b into master Jul 1, 2025
54 of 56 checks passed
@ryan953 ryan953 deleted the ryan953/ref-replayTable-simpleTable branch July 1, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants