-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(replay): Convert ReplayTable to use SimpleTable under the hood #94590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: SDK Version Hardcoding Causes Search Issues
The error message displayed when searching for 'click' fields hardcodes the required SDK version as '7.44.0'. This should instead use the MIN_REPLAY_CLICK_SDK.minVersion
constant to ensure the displayed version matches the actual requirement and updates automatically.
static/app/views/replays/table/replayIndexTable.tsx#L86-L88
sentry/static/app/views/replays/table/replayIndexTable.tsx
Lines 86 to 88 in 1d5a755
field: <strong>'click'</strong>, | |
sdkPrompt: <strong>{t('SDK version >= 7.44.0')}</strong>, | |
})} |
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work as expected!
There's some small small differences related to padding and stuff of the table rows, the header row is a bit different which makes column widths different.
Overall we're using the same table-cell implementation as before, so all the data rendering is the same.
Dropdowns also all moved to the right of the cells, no more shifting left/right depending on which column we're looking at:
Fixes REPLAY-460